I don't think it is really possible to argue that he is a failure in either of these areas. He certainly has to work hard to raise his two children in spite of the "help" that he receives from other individuals, but he manages to succeed in this task by raising two very headstrong individuals and helping to mould them into characters who look at the world around them and question the reality that so many people accept. He is definitely not a failure as a father in this regard.
In the same way, I think it is very difficult to argue that he is a failure as a lawyer. Even though he knew he was going to lose the case defending Tom Robinson, he does an excellent job and clearly shows that he is innocent. What the jury decided was no reflection on the skill of Atticus in any way. He fulfilled his job as a lawyer brilliantly, exposing the truth of the situation and defending his client to the best of his ability.
Atticus Finch is a character that can be described in many ways, but definitely the word "failure" is not a word that can be associated with who he is and how he acts in this wonderful novel.